webnn: Remove some activations not usable with recurrent ops#46678
Merged
Conversation
6f19b09 to
56beedb
Compare
clamp() and softmax() may no longer be created as MLActivations More details on the spec PR: webmachinelearning/webnn#703 Bug: 341518634 Change-Id: I7dda713c8be5454690f21c66665d90be274513f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598089 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1313205}
56beedb to
a4597eb
Compare
wpt-pr-bot
approved these changes
Jun 11, 2024
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clamp() and softmax() may no longer be created as MLActivations
More details on the spec PR:
webmachinelearning/webnn#703
Bug: 341518634
Change-Id: I7dda713c8be5454690f21c66665d90be274513f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598089
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1313205}