Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Invokers] mark clickon tests as long #45196

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 19, 2024

This change aims to avoid timeouts on invoker tests that are occurring
because of the long time between clickOn calls, which can take the test
runs over the timeout threshold on some builds on slower hardware.

Bug: 40943183
Change-Id: I5976d824dd8b98355eb69991908d7b5e57937f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372478
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276602}

This change aims to avoid timeouts on invoker tests that are occurring
because of the long time between clickOn calls, which can take the test
runs over the timeout threshold on some builds on slower hardware.

Bug: 40943183
Change-Id: I5976d824dd8b98355eb69991908d7b5e57937f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372478
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276602}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@dev-ansung
Copy link
Contributor

Unstable results

Test Subtest Results Messages
/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html invoking video with auto action is no-op FAIL: 2/10, PASS: 8/10 assert_true: expected true got false

@dev-ansung
Copy link
Contributor

Filed https://buganizer.corp.google.com/issues/331220416
@KyleJu @DanielRyanSmith Could you please admin merge? Thanks

@DanielRyanSmith DanielRyanSmith merged commit 49e8a84 into master Mar 25, 2024
18 of 20 checks passed
@DanielRyanSmith DanielRyanSmith deleted the chromium-export-cl-5372478 branch March 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants