update test to expect shadow trees to find document keyframes #44991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Yup, as resolved in w3c/csswg-drafts#1995 (comment) a few weeks after this test was committed, names are meant to "inherit" into shadow trees.
(You might want to adjust the comment too, Alan, but +1 to merging otherwise.)
BruceDai
pushed a commit
to BruceDai/wpt
that referenced
this pull request
Mar 25, 2024
…atform-tests#44991) * update test to expect shadow trees to find document keyframes * always missing updating comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the expectation for this test, as we decided in https://drafts.csswg.org/css-scoping/#shadow-names that names should inherit into descendant shadow trees.
There is not yet much interoperability in tree-scoped names: https://wiki.csswg.org/spec/css-scoping. I am working on
@font-facetests based on these@keyframetests and noticed this test needed fixing up.