-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend idbindex_get Web platform test coverage to workers. #44690
Conversation
7fa9552
to
6c23b45
Compare
6c23b45
to
13165cb
Compare
13165cb
to
ddbf9be
Compare
web_tests/external/wpt/IndexedDB/ tests are only testing behavior in window environment. Extend the tests to cover different workers (dedicated, serviceworker, sharedworker). Tests related to idbindex_get.htm have been extended. Bug: 41455766 Change-Id: Ib2ffb0715a5aa994a92cd22dfa36932cddb4e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311293 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Commit-Queue: Sneha Agarwal <snehagarwal@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1264153}
ddbf9be
to
fbd85fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
@KyleJu @DanielRyanSmith Pinged bug about Firefox stability timeout. Please force merge in the meantime, thanks! |
web_tests/external/wpt/IndexedDB/ tests are only testing behavior in window environment.
Extend the tests to cover different workers (dedicated, serviceworker, sharedworker).
Tests related to idbindex_get.htm have been extended.
Bug: 41455766
Change-Id: Ib2ffb0715a5aa994a92cd22dfa36932cddb4e637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311293
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Sneha Agarwal <snehagarwal@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1264153}