Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend idbindex_get Web platform test coverage to workers. #44690

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 21, 2024

web_tests/external/wpt/IndexedDB/ tests are only testing behavior in window environment.
Extend the tests to cover different workers (dedicated, serviceworker, sharedworker).
Tests related to idbindex_get.htm have been extended.

Bug: 41455766

Change-Id: Ib2ffb0715a5aa994a92cd22dfa36932cddb4e637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311293
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Sneha Agarwal <snehagarwal@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1264153}

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Extending Web platform test coverage Extending idbindex_get Web platform test coverage Feb 21, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5311293 branch 2 times, most recently from 7fa9552 to 6c23b45 Compare February 22, 2024 01:25
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Extending idbindex_get Web platform test coverage Extend Web platform test coverage to workers. Feb 22, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Extend Web platform test coverage to workers. Extend idbindex_get Web platform test coverage to workers. Feb 22, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot marked this pull request as ready for review February 22, 2024 20:22
web_tests/external/wpt/IndexedDB/ tests are only testing behavior in window environment.
Extend the tests to cover different workers (dedicated, serviceworker, sharedworker).
Tests related to idbindex_get.htm have been extended.

Bug: 41455766

Change-Id: Ib2ffb0715a5aa994a92cd22dfa36932cddb4e637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311293
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Sneha Agarwal <snehagarwal@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1264153}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/IndexedDB/idbindex_get.any.serviceworker.html OK: 9/10, TIMEOUT: 1/10
/IndexedDB/idbindex_get.any.serviceworker.html IDBIndex.get() - returns the record PASS: 9/10, MISSING: 1/10
/IndexedDB/idbindex_get.any.html OK: 9/10, TIMEOUT: 1/10
/IndexedDB/idbindex_get.any.html IDBIndex.get() - returns the record NOTRUN: 1/10, PASS: 9/10
/IndexedDB/idbindex_get.any.worker.html OK: 9/10, TIMEOUT: 1/10
/IndexedDB/idbindex_get.any.worker.html IDBIndex.get() - returns the record NOTRUN: 1/10, PASS: 9/10

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@jonathan-j-lee
Copy link
Contributor

@KyleJu @DanielRyanSmith Pinged bug about Firefox stability timeout. Please force merge in the meantime, thanks!

@KyleJu KyleJu merged commit 3cc0431 into master Feb 27, 2024
19 of 21 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-5311293 branch February 27, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants