Add WPT for referrer handling in HTTPS Upgrades #43676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 14, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5122096
branch
from
94ad210
to
e920929
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5122096
branch
3 times, most recently
from
7e3bc67
to
3276e8d
Compare
This WPT test checks that HTTPS Upgrading does not drop referrer information when: 1. Referrer policy is no-referrer-when-downgrade 2. A navigation is made to an URL is HTTP 3. Navigated URL is successfully upgraded to HTTPS In this scenario, the upgraded HTTPS URL should get the referrer information since the connection was never downgraded to an unsafe URL. The current implementation of HTTPS Upgrades in Chrome doesn't pass this test, dropping the referrer. Bug: 1394910 Change-Id: I459e5fcdc97adc19dc42aa5ba1ca0b1617d2158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5122096 Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1237834}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5122096
branch
from
3276e8d
to
49df45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WPT test checks that HTTPS Upgrading does not drop referrer
information when:
In this scenario, the upgraded HTTPS URL should get the referrer
information since the connection was never downgraded to an unsafe
URL.
The current implementation of HTTPS Upgrades in Chrome doesn't pass
this test, dropping the referrer.
Bug: 1394910
Change-Id: I459e5fcdc97adc19dc42aa5ba1ca0b1617d2158d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5122096
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1237834}