CloseWatcher: add requestClose() #41201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 27, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4721666
branch
from
c81b7c8 to
92932d0
Compare
Or rather, rename close() to requestClose(), and then add close(). Follows whatwg/html@63fb283, per WICG/close-watcher#28. Bug: 1171318 Change-Id: Ic1c6dff2440f38c04f7ffaaa19188403a46b9adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721666 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1176384}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4721666
branch
from
92932d0 to
5aa715b
Compare
|
Looks like we need to manually merge this one so that crrev.com/c/4722573 and crrev.com/c/4721668, which are later in the chain but also already merged downstream, apply cleanly; see exporter log. |
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Or rather, rename close() to requestClose(), and then add close(). Follows whatwg/html@63fb283, per WICG/close-watcher#28. Bug: 1171318 Change-Id: Ic1c6dff2440f38c04f7ffaaa19188403a46b9adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721666 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1176384} Co-authored-by: Domenic Denicola <domenic@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or rather, rename close() to requestClose(), and then add close().
Follows whatwg/html@63fb283,
per WICG/close-watcher#28.
Bug: 1171318
Change-Id: Ic1c6dff2440f38c04f7ffaaa19188403a46b9adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721666
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1176384}