-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the event handler IDL attribute compilation realm #4089
base: master
Are you sure you want to change the base?
Conversation
ChromeTesting revision cd1b12c4693a6f5a97d245fa9258bd1617e8d449 All results/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
|
FirefoxTesting revision 41d510a All results/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
|
ChromeTesting revision 41d510a All results/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
|
FirefoxTesting revision 2358a06 All results/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
|
ChromeTesting revision 2358a06 All results/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
|
719e19c
to
41fb32f
Compare
FirefoxTesting revision a21bf48 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
|
ChromeTesting revision a21bf48 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
|
ChromeTesting revision 6b1b9e5 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
FirefoxTesting revision 6b1b9e5 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
} | ||
|
||
case "error not expected": { | ||
console.log("got here"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails lint check
FirefoxTesting revision a87c397 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
ChromeTesting revision a87c397 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
FirefoxTesting revision a87c397 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
ChromeTesting revision a87c397 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
5932d75
to
6bcec5c
Compare
FirefoxTesting revision 6f58d17 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
ChromeTesting revision 6f58d17 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
}); | ||
|
||
// The test passes if no error events have been fired within this time. | ||
setTimeout(t.step_func_done(), 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're supposed to use t.step_timeout(() => { t.done(); }, 10);
so certain environments that need longer timeouts can do that. But also 10ms is too short for stable results; I believe @jgraham has recommended no less than 2000ms.
FirefoxTesting revision d86386b All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
Testing revision d86386b in Chrome All results were stable/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
(Comment edited by @zcorpan to experiment with |
Is there a particular reason to change the tools submodule? |
Sigh, no, just some branch-switching confusion. Will fix. |
See whatwg/html#1956. In particular, this tests that: - Event handler IDL attributes are compiled in the right realm - Event handler IDL attribute compilation, setTimeout, and requestAnimationFrame do not "report the exception" for inactive documents
f2699d1
to
d7e3da7
Compare
FirefoxTesting revision 7847657 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
ChromeTesting revision 7847657 All results/html/webappapis/timers/compile-errors.html
/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html
/html/webappapis/animation-frames/callback-exception.html
/workers/Worker_ErrorEvent_after_navigation.htm
|
See whatwg/html#1956. Not ready to merge until we figure that one out.