[webnn] Add float32 test for more WebNN Reduction operations #39467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduceL1 / reduceL2 / reduceLogSum / reduceLogSumExp / reduceSumSquare
fdwr
approved these changes
Apr 20, 2023
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Minor naming proposal, but otherwise looks correct (and everything matches my spreadsheet :b). Thanks.
webnn/resources/utils.js
Outdated
| case 'reduceL1': | ||
| case 'reduceProduct': | ||
| case 'reduceSum': | ||
| // directly use above computed tolerance |
There was a problem hiding this comment.
This all looks correct, but rather than assign a tolerance above and then later replace that tolerance with a new value or keep it via switch fallthrough, I think it would be clearer to rename tolerance on line 233 to something like reducedElementCount, and then here say:
tolerance = reducedElementCount
...
tolerance = reducedElementCount * 2 + 18
Functionally it's the same, but semantically the relationship is more apparent.
Honry
approved these changes
Apr 25, 2023
fdwr
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @dontcallmedom PTAL, thanks.