[webnn] Add float32 tests for WebNN hardSigmoid op #39430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Apr 19, 2023
| 0.962285784541856, | ||
| 0.2570918415891237, | ||
| 0.5411237762597576, | ||
| -0.7982109817680292, |
There was a problem hiding this comment.
Beware that mixing negative and positive numbers in addition can cause subtraction of nearly equal numbers, meaning catastrophic cancellation and potentially exceeding the ULP. Consider using positive inputs here and other cases. Similarly using a negative scale with positive beta could yield the same issue (unless the inputs were negative, in which case the inputs and scale would cancel signs, and so that would be fine).
clamp(a * alpha + beta, 0, 1)); defaults alpha = 0.2, beta = 0.5
Contributor
Author
There was a problem hiding this comment.
Done to update test data to avoid catastrophic cancellation, please take another look, thanks! @fdwr
BruceDai
force-pushed
the
add_webnn_hardSigmoid_tests
branch
from
e362ff9 to
80536cf
Compare
BruceDai
force-pushed
the
add_webnn_hardSigmoid_tests
branch
from
80536cf to
89e1982
Compare
Honry
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @dontcallmedom PTAL, thanks.