Fix selectmenu's button for writing-mode #39135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 22, 2023
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4359392
branch
2 times, most recently
from
e90d51a
to
b3ed46d
Compare
Before this patch, the selectmenu's button would not rotate when writing-mode is asking it to, but based on the mockups from this issue we should be rotating the button: openui/open-ui#600 Fixed: 1426702 Bug: 1427573 Change-Id: Ib2b4884efa518d2a445638f99d87be66e87138f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4359392 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1121829}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4359392
branch
from
b3ed46d
to
15aec23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the selectmenu's button would not rotate when
writing-mode is asking it to, but based on the mockups from this issue
we should be rotating the button:
openui/open-ui#600
Fixed: 1426702
Bug: 1427573
Change-Id: Ib2b4884efa518d2a445638f99d87be66e87138f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4359392
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121829}