Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools tests #38613

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix tools tests #38613

merged 3 commits into from
Feb 21, 2023

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Feb 21, 2023

No description provided.

@gsnedders
Copy link
Member

Also ignore errors that occur when trying to close the file handles.

Can you at least say why this is needed, @jgraham?

@jgraham
Copy link
Contributor Author

jgraham commented Feb 21, 2023

Because we were seeing Broken Pipe Error sometimes. But also because any error during cleanup seems like it should at worst be a warning; the worst that can happen is we leak a file handle (which admittedly isn't great), but given that file operations are intrinsically unreliable, but failure to close a file shouldn't be fatal, I'm not sure what would be better.

@jgraham jgraham enabled auto-merge (rebase) February 21, 2023 19:57
@jgraham jgraham merged commit 66e9d1e into master Feb 21, 2023
@jgraham jgraham deleted the fix_tools_tests branch February 21, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants