Test that requestFullscreen() works for svg:svg but not svg:rect #3830
Conversation
|
@upsuper PTAL. element-request-fullscreen-svg-rect-manual.html is failing in Firefox and in Chrome, so you might want to file a bug for that. |
|
Thanks. Filed bug 1305928 for that. |
|
Taking that as review and merging, please shout if you didn't actually review and find something wrong after the fact. |
| var svg = document.querySelector("svg"); | ||
| assert_true(svg instanceof SVGSVGElement); | ||
| trusted_request(svg, document.body); | ||
| document.onfullscreenchange = t.step_func_done(); |
There was a problem hiding this comment.
In this test, t.step_func_done() would be called twice. Would that be counted as an error somehow?
In Gecko's test, we do count extra call to ending function as a test failure. Not sure whether wpt is lenient on this.
There was a problem hiding this comment.
I think this test can only call t.step_func_done() once, where would the second time be?
In testharness.js, nothing that happens after the first failure or done event matters, so in general it's fine if there are two ways the test can pass and if both happen.
There was a problem hiding this comment.
The second time would be when exiting fullscreen, I think. If anything after first done doesn't count, then probably fine.
There was a problem hiding this comment.
Ah, the test actually never exits fullscreen, which I guess is annoying when testing manually. If it did it'd still not be necessary to clean up this event handler to avoid the extra call to t.step_func_done() though.
https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen