Add webnn squeeze tests #37352
Merged
Add webnn squeeze tests #37352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
approved these changes
Dec 8, 2022
| ], | ||
| "type": "float32" | ||
| } | ||
| } |
There was a problem hiding this comment.
We should test the corner case of all 1's, which yields a single scalar value.
"shape": [1, 1, 1, 1] -> []
Of course, this scalar will probably be filled with leading 1's before reaching backend implementations.
BruceDai
force-pushed
the
add_webnn_squeeze_tests
branch
from
5622ed7 to
aadbca1
Compare
fdwr
approved these changes
Dec 9, 2022
BruceDai
force-pushed
the
add_webnn_squeeze_tests
branch
from
aadbca1 to
ec3c2b6
Compare
Contributor
Author
|
@dontcallmedom @Honry All checks passed, PTAL, thanks. |
fdwr
approved these changes
Jan 6, 2023
Honry
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @dontcallmedom PTAL, thanks.