Skip to content

Add webnn binary tests #37337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Honry merged 4 commits into from
Jan 12, 2023
Merged

Add webnn binary tests #37337

Honry merged 4 commits into from
Jan 12, 2023

Conversation

@BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Dec 6, 2022

No description provided.

@BruceDai
Copy link
Contributor Author

BruceDai commented Dec 6, 2022

@fdwr @Honry @huningxin @dontcallmedom PTAL, thanks.

fdwr
fdwr reviewed Dec 9, 2022
View reviewed changes
webnn/resources/test_data/div.json Outdated
}
},
{
"name": "div two float32 2D tensors",
Copy link

@fdwr fdwr Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Propose deleting "two", because can the input count ever not be two? (so doesn't really add more information to the test name) Plus, you didn't use "two" below for other names "div float32 broadcast 2D to 4D".

Copy link
Contributor Author

@BruceDai BruceDai Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Updated.

@BruceDai BruceDai force-pushed the add_webnn_binary_tests branch from 5a83df6 to f7c7f8e Compare December 9, 2022 08:04
@BruceDai BruceDai mentioned this pull request Dec 13, 2022
Closed
@BruceDai
Copy link
Contributor Author

BruceDai commented Dec 21, 2022 •
edited
Loading

@Honry When running tests in workers, there're 'Not Run' results caused by test invoked after promise_setup, the new commit is to fix it, PTAL, thanks.
If this solution is OK, I would update others relevant WebNN operation tests PRs.

Honry
Honry approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BruceDai BruceDai force-pushed the add_webnn_binary_tests branch from 5c156ae to eaae1a4 Compare December 22, 2022 03:10
@BruceDai
Copy link
Contributor Author

BruceDai commented Dec 22, 2022

@Honry I fixed the same issues in #37351 #37379 and #37380, please also take a look, thanks.
For other operation tests, I will update them when rebasing those PRs for merging.

@BruceDai BruceDai force-pushed the add_webnn_binary_tests branch from eaae1a4 to cada6e5 Compare January 12, 2023 08:21
@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 12, 2023

@Honry All checks passed, PTAL, thanks.

@Honry Honry merged commit b550210 into web-platform-tests:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Honry Honry Honry approved these changes

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

+1 more reviewer

@fdwr fdwr fdwr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Honry Honry

Labels

webnn wg-s_webmachinelearning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BruceDai @fdwr @Honry @wpt-pr-bot @moz-wptsync-bot