Add webnn slice tests #37072
Merged
Add webnn slice tests #37072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceDai
force-pushed
the
add_webnn_slice_tests
branch
from
fb2ab9c to
bce8fcd
Compare
This was referenced Nov 30, 2022
Merged
fdwr
reviewed
Dec 2, 2022
| } | ||
| }, | ||
| "starts": [2, 2], | ||
| "sizes": [2, 4], |
There was a problem hiding this comment.
It's interesting that WebNN chose starts and sizes, whereas other frameworks I'm familiar with chose starts and ends, which makes it easier to specify relative endpoints on both ends. That will require some massaging from frameworks to WebNN. Shrug, pro's/con's. (no action expected)
Also the slice asymmetry between start and end ranges for negative values is weird 🤨, but that's a spec oddity (https://www.w3.org/TR/webnn/#api-mlgraphbuilder-slice), and the code looks fine as-is, according to the current version of the spec anyway.
Contributor
Author
BruceDai
force-pushed
the
add_webnn_slice_tests
branch
from
bce8fcd to
3da19a2
Compare
Contributor
Author
|
@Honry All checks passed, PTAL, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @huningxin @dontcallmedom PTAL, thanks.