Add webnn reshape tests #37070
Merged
Add webnn reshape tests #37070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceDai
force-pushed
the
add_webnn_reshape_tests
branch
3 times, most recently
from
311f421 to
eec04f9
Compare
This was referenced Nov 30, 2022
Merged
fdwr
reviewed
Dec 2, 2022
| @@ -0,0 +1,272 @@ | |||
| { | |||
| "tests": [ | |||
There was a problem hiding this comment.
How about one test case coming from or going to 1D? e.g. "newShape": [24],
There was a problem hiding this comment.
And/or "newShape: [-1] which would consolidate all elements into a single 1D tensor. I don't really care which, but I think we should have at least one 1D test case.
Contributor
Author
There was a problem hiding this comment.
Thanks, I've added such tests. Please take another look.
fdwr
approved these changes
Dec 2, 2022
BruceDai
force-pushed
the
add_webnn_reshape_tests
branch
from
29f21e0 to
481a16f
Compare
Contributor
Author
|
@Honry All checks passed, PTAL, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @huningxin @dontcallmedom PTAL, thanks.