Add webnn matmul tests #37069
Merged
Add webnn matmul tests #37069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceDai
force-pushed
the
add_webnn_matmul_tests
branch
from
520e485 to
fad8ca5
Compare
This was referenced Nov 30, 2022
Merged
fdwr
approved these changes
Dec 3, 2022
fdwr
reviewed
Dec 3, 2022
webnn/resources/utils.js
Outdated
| */ | ||
| const getMatmulPrecisionTolerance = (resources) => { | ||
| // Matmul : Compute the matrix product of two input tensors. | ||
| // If a is 1-D, it is converted to a 2-D tensor by prepending a 1 to its dimensions, [n] -> [1, n] |
There was a problem hiding this comment.
[minor] Would revise comment, because currently it sounds like the comment is saying that the logic below converts the 1D tensor to 2D, but actually it's WebNN that does this conversion. How about:
// If a is 1-D, WebNN converts it to a 2-D tensor by prepending a 1 to its dimensions, [n] -> [1, n].
// So we can just always check the last dimension here.
fdwr
approved these changes
Dec 3, 2022
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Looks like you covered the important cases, broadcasting 1D/2D, 2D/1D.
BruceDai
force-pushed
the
add_webnn_matmul_tests
branch
from
fad8ca5 to
4904115
Compare
fdwr
approved these changes
Dec 5, 2022
BruceDai
force-pushed
the
add_webnn_matmul_tests
branch
from
4904115 to
1d1c467
Compare
Contributor
Author
|
@Honry All checks passed, PTAL, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @huningxin @dontcallmedom PTAL, thanks.