-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[webnn] Add tests for concat operation. #36782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Honry
merged 9 commits into
web-platform-tests:master
from
BruceDai:add_webnn_concat_tests
Jan 6, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0784ced
[webnn] Add tests for concat operation.
BruceDai afca329
[webnn] Updated concat tests to align with latest WebNN API Spec
BruceDai b72f3e3
[webnn] Optimize concat tests by addressing comments.
BruceDai 6bb4588
[webnn] Align the usage for sync and async functions.
BruceDai 5d85aef
[webnn] Optimize concat tests with renaming variables.
BruceDai 23c3f45
[webnn] Optimized concat tests by moving if condition checking out of…
BruceDai ecaf2a3
[webnn] Refined code to reuse for other operation tests.
BruceDai f9c75c5
[webnn] Address comments to move nested functions outside.
BruceDai de07f07
[webnn] More refined code to reuse for other operation tests.
BruceDai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // META: title=test WebNN API concat operation | ||
| // META: global=window,dedicatedworker | ||
| // META: script=./resources/utils.js | ||
| // META: timeout=long | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // https://webmachinelearning.github.io/webnn/#api-mlgraphbuilder-concat | ||
|
|
||
| const buildConcat = (builder, resources) => { | ||
| // MLOperand concat(sequence<MLOperand> inputs, long axis); | ||
| const namedOutputOperand = {}; | ||
| const inputOperands = []; | ||
| for (let input of resources.inputs) { | ||
| inputOperands.push(builder.input(input.name, {type: input.type, dimensions: input.shape})); | ||
| } | ||
| namedOutputOperand[resources.expected.name] = builder.concat(inputOperands, resources.axis); | ||
| return namedOutputOperand; | ||
| }; | ||
|
|
||
| testWebNNOperation('concat', '/webnn/resources/test_data/concat.json', buildConcat); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that sets
inputOperandsandinputslook common for other operator tests. Could they be extract to utils.js?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huningxin Thanks for your suggestions, I will try to optimize setting
inputOperands,inputsandoutputsin the next PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building inputs from JSON looks good.