[last-baseline] Set multicol last-baseline to lowest of all fragments #36316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 6, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3931189
branch
from
8e477f0
to
c0b21d7
Compare
See: w3c/csswg-drafts#7639 Effectively we need to propagate the last baseline from the lowest of all fragments. This does change the baseline of a multi-col within a inline-block context. Bug: 885175 Change-Id: I8385f89cbe0bb3cc89fc972546f56ddd9ae391bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931189 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1056833}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3931189
branch
from
c0b21d7
to
3524140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: w3c/csswg-drafts#7639
Effectively we need to propagate the last baseline from the lowest
of all fragments. This does change the baseline of a multi-col within
a inline-block context.
Bug: 885175
Change-Id: I8385f89cbe0bb3cc89fc972546f56ddd9ae391bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931189
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1056833}