[css-grid] Fixed inclusion of CSS Grid testing-utils.js #35462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
javifernandez,
mrego,
plinss,
rachelandrew,
svillar and
tabatkins
SebastianZ
changed the title
svillar
approved these changes
Sep 1, 2022
mrego
requested changes
Sep 5, 2022
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| <script src="/resources/testharness.js"></script> | |||
| <script src="/resources/testharnessreport.js"></script> | |||
| <script src="../grid-definition/support/testing-utils.js"></script> | |||
| <script src="support/testing-utils.js"></script> | |||
There was a problem hiding this comment.
This file doesn't exist. So this breaks these tests.
You could move testing-utils.js to /css/css-grid/support (similar to grid-child-utils.js) and use the full path where testing-utils.js is used (in both grid-definition and layout-algorithm folders).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL path to testing-utils.js for CSS Grid was wrong for a few tests. This change aligns the path with the other tests.
See https://test.csswg.org/harness/test/css-grid-1_dev/single/grid-flex-track-intrinsic-sizes-003/format/html5/ as an example for where this is currently causing a test failure.
Sebastian