Iframes with missing redirect location should fire load event and queue RT entry #33317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
changed the title
3 tasks
yoavweiss
reviewed
Mar 23, 2022
| t.add_cleanup(() => frame.remove()); | ||
| await new Promise(resolve => { | ||
| frame.addEventListener('load', resolve); | ||
| frame.src = 'resources/bad-redirect.py'; |
There was a problem hiding this comment.
Nit: Maybe rename to redirect-without-location.py or add a comment as to why this redirect is bad?
| document.body.appendChild(frame); | ||
| }); | ||
|
|
||
| const entries = performance.getEntriesByName(frame.src); |
There was a problem hiding this comment.
Does this work? I thought getEntriesByName needs the absolute URL..
There was a problem hiding this comment.
Yes! The src attribute returns the full URL
| <script src="/resources/testharnessreport.js"></script> | ||
| <body> | ||
| <script> | ||
| promise_test(async t => { |
There was a problem hiding this comment.
High level note - would be nice to use the resource-loaders.js infra for this. Would also be nice to test (if not tested already elsewhere) that it's only the initial src that's exposed and not the redirected one.
There was a problem hiding this comment.
The latter is tested elsewhere.
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Mar 25, 2022
…ue RT entry (web-platform-tests#33317) * Iframes with missing redirect location should fire load event and queue RT entry See whatwg/html#7531 * Rename and use loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iframes with missing redirect location (e.g. 302 response code and no
locationheader) should fire load event and queue RT entry