Use IsSameOriginWith for showPicker cross-origin iframe check #31908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 6, 2021
This CL changes from IsSameOriginDomainWith to IsSameOriginWith the check for cross-origin iframes when showPicker() is called following spec change[1]. [1] whatwg/html#7319 (comment) Change-Id: Ic21ec96e241cad730d6e93a7b635cf9107f48023 Bug: 939561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310677 Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#948890}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3310677
branch
from
280bcd5
to
9d59b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL changes from IsSameOriginDomainWith to IsSameOriginWith the
check for cross-origin iframes when showPicker() is called following
spec change[1].
[1] whatwg/html#7319 (comment)
Change-Id: Ic21ec96e241cad730d6e93a7b635cf9107f48023
Bug: 939561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310677
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#948890}