Test Web Neural Network API by WebNN-polyfill #31771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceDai
changed the title
Contributor
|
@web-platform-tests/admins help? I'm not clear why the jobs are failing |
Contributor
Contributor
|
But as a general comment, adding a polyfill like this to test something seems highly unusual, since it's not helping implementors (except the polyfill implementors) and gives a misleading impression of the status of browser implementations. Also using scripts outside wpt isn't allowed (Firefox is configured to crash in CI for this case, as you can see at https://wpt.fyi/results/webnn/idlharness.https.any.html?diff&filter=ADC&run_id=5729986758574080&run_id=5705420837486592 ). If you want to include the behaviour of a polyfill in wpt.fyi results I think we need a broader discussion about how to achieve that. |
BruceDai
force-pushed
the
webnn_idl_polyfill
branch
from
dee5168 to
1b7ed97
Compare
Contributor
Author
|
Thanks for your feedbacks. Close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the previous comment by @dontcallmedom on #31201,
I added this pr of testing Web Neural Network API by WebNN-polyfill.
@dontcallmedom @Honry PTAL, thanks.