createElement now sets namespace from contentType #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/6388 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
| @@ -39,15 +43,15 @@ | |||
| }, "Created element's namespace in created XML document"); | |||
| test(function() { | |||
| testDoc(document.implementation.createDocument("http://www.w3.org/1999/xhtml", "html", null), | |||
| "application/xml"); | |||
| "application/xhtml+xml"); | |||
There was a problem hiding this comment.
This change for createDocument is not in the DOM standard yet?
There was a problem hiding this comment.
Correct, as noted in the commit message. I expect it will be there within a couple of days, and didn't want to bother updating the test twice. If it actually gets rejected, I'll fix the test then.
|
LGTM % the MathML case |
ayg
force-pushed
the
createElement-namespace
branch
from
0452d53
to
c7165af
Compare
ivanzr
pushed a commit
to ivanzr/web-platform-tests
that referenced
this pull request
Jun 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for whatwg/dom@c8ae9cbd. This assumes that whatwg/dom#217 is
resolved, so createDocument() is expected to provide a contentType based
on the namespace instead of always application/xml.