Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1683639] Add zipp to third_party #26972

Merged
merged 2 commits into from
Dec 23, 2020
Merged

[Gecko Bug 1683639] Add zipp to third_party #26972

merged 2 commits into from
Dec 23, 2020

Conversation

moz-wptsync-bot
Copy link
Collaborator

This is required by the vendored pytest, but was missed in PR
26704. The vendoring is done simply by extracting the source package
into the third_party directory.

Differential Revision: https://phabricator.services.mozilla.com/D100238

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683639
gecko-commit: 07a16a5ecab94c6a7e862742ad85c9eb416d4a2b
gecko-reviewers: whimboo

This is required by the vendored pytest, but was missed in PR
26704. The vendoring is done simply by extracting the source package
into the third_party directory.

Differential Revision: https://phabricator.services.mozilla.com/D100238

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683639
gecko-commit: 07a16a5ecab94c6a7e862742ad85c9eb416d4a2b
gecko-reviewers: whimboo
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@jgraham
Copy link
Contributor

jgraham commented Dec 21, 2020

I'm so confused. This is required in mozilla-central but just seems to break stuff here :/

This is the last Python 2 supporting version
@jgraham jgraham merged commit 8e32839 into master Dec 23, 2020
@jgraham jgraham deleted the gecko/1683639 branch December 23, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants