Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import maps: rearrange and update WPTs #26239

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 22, 2020

  • Flips the pass condition for worker interaction. A module worker does
    not impact the import map of the outer page, since its constructor
    takes a URL, not a specifier that needs resolution.

  • Removes leftover built-in module support and @std references.

  • Removes .tentative filename suffixes.

  • Renames "common" to "data-driven".

  • Renames parsing.tentative.https.html to parsing-internal.https.html so
    that all internal tests to have -internal in the name. We should move
    them out of WPT (or convert them to not require internals),
    eventually, but for now making the difference clear is good.

  • Moves "core" tests up to the top level.

  • Removes references to future fetch-based import maps and Chromium
    implementation limitations.

  • Adds OWNERS and META.yml

Bug: 1026809
Change-Id: I1807468a813ebee416cd8e05a272dbae6ea157bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491616
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825559}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

* Flips the pass condition for worker interaction. A module worker does
  not impact the import map of the outer page, since its constructor
  takes a URL, not a specifier that needs resolution.

* Removes leftover built-in module support and @std references.

* Removes .tentative filename suffixes.

* Renames "common" to "data-driven".

* Renames parsing.tentative.https.html to parsing-internal.https.html so
  that all internal tests to have -internal in the name. We should move
  them out of WPT (or convert them to not require internals),
  eventually, but for now making the difference clear is good.

* Moves "core" tests up to the top level.

* Removes references to future fetch-based import maps and Chromium
  implementation limitations.

* Adds OWNERS and META.yml

Bug: 1026809
Change-Id: I1807468a813ebee416cd8e05a272dbae6ea157bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491616
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825559}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants