Add WPT tests for TransformInterop feature. #23865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 29, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2197895
branch
7 times, most recently
from
7fae980
to
495e0fc
Compare
Also, fix one bug revealed by these tests: getBoundingClientRect was incorrect in cases where a transform is present, the containing block has a perspective transform, and there are intervening DOM elements. This was correctly implemented in PaintPropertyTreeBuilder, but getBoundingClientRect uses another code path that goes through LayoutObject::GetTransformFromContainer. Bug: 1008483 Change-Id: Id075e3f3cfd9d6c725a724ad03534a4a2fc1d377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197895 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775848}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2197895
branch
from
495e0fc
to
8e92aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix one bug revealed by these tests: getBoundingClientRect
was incorrect in cases where a transform is present, the containing
block has a perspective transform, and there are intervening DOM
elements. This was correctly implemented in PaintPropertyTreeBuilder,
but getBoundingClientRect uses another code path that goes through
LayoutObject::GetTransformFromContainer.
Bug: 1008483
Change-Id: Id075e3f3cfd9d6c725a724ad03534a4a2fc1d377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197895
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775848}