Update cookie WPT expectations to support nameless cookies. #21093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 8, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1982551
branch
from
3fe9b9c to
4ed0db2
Compare
Based on the discussion in [1], we should change the spec to support nameless cookies parsed from headers like `Set-Cookie: foo`. This patch updates the WPT expectations accordingly. [1]: httpwg/http-extensions#159 Bug: 1037996 Change-Id: Iefabea524377857d524c74457153347a107401ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982551 Reviewed-by: Lily Chen <chlily@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#729807}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1982551
branch
from
4ed0db2 to
65c8b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in 1, we should change the spec to support
nameless cookies parsed from headers like
Set-Cookie: foo. This patchupdates the WPT expectations accordingly.
Bug: 1037996
Change-Id: Iefabea524377857d524c74457153347a107401ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982551
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729807}