Add coverage for blend operations #1822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests into 2dcontext-coverage
…to 2dcontext-coverage
…latform-tests into 2dcontext-coverage Conflicts: 2dcontext/tools/tests2d.yaml
…latform-tests into 2dcontext-coverage Conflicts: 2dcontext/tools/tests2d.yaml
|
Critic review: https://critic.hoppipolla.co.uk/r/4980 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
These tests from @acomminos need review from @junov or other canvas SME. @Ms2ger? |
junov
suggested changes
Oct 31, 2016
| ('copy', '1', '0'), | ||
| ('lighter', '1', '1'), | ||
| # Composite operation tests | ||
| # <http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2007-March/010608.html> |
There was a problem hiding this comment.
This reference is out of date. The current version of the whatwg spec references the CSS blending and Compositing spec for enumerating available modes.
There are trivial compositing modes in that spec that are missing here: destination and clear. Also, there are the plus-darker and plus-lighter modes
sideshowbarker
added
awaiting submitter response
and removed
stale:awaiting-review
labels
gsnedders
added
stale:awaiting-submitter-response
and removed
awaiting submitter response
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KyleFung and I from Mozilla have been working on adding coverage for blend operations to Philip Taylor's compositing tests. Please let us know if there are any changes to be made!