Expose kv-storage built-in module only on SecureContexts #17863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1702754
branch
from
eabc0d9
to
ace4ba2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1702754
branch
2 times, most recently
from
6289c50
to
09e4bfc
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1702754
branch
2 times, most recently
from
f35e4ef
to
9fff1aa
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1702754
branch
from
9fff1aa
to
66b087b
Compare
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1702754
branch
from
66b087b
to
3bd3925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds actual restriction in Blink implementation.
This CL also modifies tests and expectations to match with
the current Blink built-in/import maps infra.
A subtest in WPT test
import-statement.htmlis failingbecause the current Blink implementation is based on
pre-import-map spec and thus
importing unavailable built-in causes fetch error.
See 'import 'std:nonexistent';' row of
WICG/import-maps#159.
Bug: 977470
Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691821}