Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #15512 due to TC infrastructure/ failure #16022

Merged
merged 3 commits into from
Mar 22, 2019

Conversation

gsnedders
Copy link
Member

Reverts #15512. This should make TC infrastructure/ pass again.

cc @foolip @Hexcles

This reverts commit 09f993e.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
This reverts commit a83f274.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
This reverts commit c9e9064.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
@foolip
Copy link
Member

foolip commented Mar 22, 2019

@gsnedders what was the failure? Can you pepper more failing expectations until it works? It did pass CI when the PR was merged.

@jgraham
Copy link
Contributor

jgraham commented Mar 22, 2019

TEST-UNEXPECTED-FAIL | /infrastructure/testdriver/actions/actionsWithKeyPressed.html | TestDriver actions: actions with key pressed - assert_array_equals: lengths differ, expected 3 got 1
@http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:64:34
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25
Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1627:32
promise callback*@http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:64:6
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25
async_test@http://web-platform.test:8000/resources/testharness.js:576:22
@http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:39:1
TEST-UNEXPECTED-OK | /infrastructure/testdriver/actions/actionsWithKeyPressed.html | expected ERROR

Also having an infrastructure test that all browsers are expected to fail seems pretty odd.

@gsnedders
Copy link
Member Author

@foolip It seems to have never run the infrastructure tests prior to merging (they don't appear under Travis or TaskCluster!). Per our revert policy, I'd rather just revert the PR causing breakage on master that landed without ever running infrastructure and let the original authors figure out what to do.

@foolip foolip merged commit 288222e into web-platform-tests:master Mar 22, 2019
@foolip
Copy link
Member

foolip commented Mar 22, 2019

@gsnedders merged and I'll send a new PR to see what it does right away.

Also having an infrastructure test that all browsers are expected to fail seems pretty odd.

This is because ChromeDriver isn't released as often as Chrome itself. At least I think so. In other words, things will break again when ChromeDriver is updated.

foolip added a commit that referenced this pull request Mar 22, 2019
@gsnedders gsnedders deleted the revert-15512 branch March 22, 2019 14:24
@Hexcles
Copy link
Member

Hexcles commented Mar 22, 2019

I think infrastructure tests did run in #15512 , but because of Taskcluster Checks migration, @jgraham temporarily stopped requiring Taskcluster checks so the PR slipped through...

foolip added a commit that referenced this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants