-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #15512 due to TC infrastructure/ failure #16022
Conversation
This reverts commit 09f993e. Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
This reverts commit a83f274. Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
This reverts commit c9e9064. Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
@gsnedders what was the failure? Can you pepper more failing expectations until it works? It did pass CI when the PR was merged. |
Also having an infrastructure test that all browsers are expected to fail seems pretty odd. |
@foolip It seems to have never run the infrastructure tests prior to merging (they don't appear under Travis or TaskCluster!). Per our revert policy, I'd rather just revert the PR causing breakage on master that landed without ever running infrastructure and let the original authors figure out what to do. |
@gsnedders merged and I'll send a new PR to see what it does right away.
This is because ChromeDriver isn't released as often as Chrome itself. At least I think so. In other words, things will break again when ChromeDriver is updated. |
Reverts #15512. This should make TC infrastructure/ pass again.
cc @foolip @Hexcles