Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-tables] Add some subpixel collapsed border tests #15449

Merged
merged 1 commit into from
Feb 20, 2019

Commits on Feb 20, 2019

  1. [css-tables] Add some subpixel collapsed border tests

    This CL contains tests only, no behavior change.
    
    Chrome passes only 001, no matter the device pixels.
    Safari-lodpi and Firefox-lodpi pass only 001 and 002.
    EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002,
    and 003.
    
    From a plain reading of the tables spec the 003 test is correct. But
    given its rampant failure (only EdgeHTML passes when 1x device pixel per
    CSS pixel), it'd be reasonable to codify the current empirical behavior
    somewhere, if it's not already in a place that I missed.
    
    Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64
    pixel precision but that's not confirmed.
    
    Note that these tests will become invalid if the proposal in
    w3c/csswg-drafts#606 is adopted.
    
    Bug: 377847
    Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940
    Reviewed-on: https://chromium-review.googlesource.com/c/1477334
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: David Grogan <dgrogan@chromium.org>
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#633538}
    davidsgrogan authored and chromium-wpt-export-bot committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    7a820b5 View commit details
    Browse the repository at this point in the history