Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase fixes in css/CSS2/borders #10755

Closed
wants to merge 5 commits into from
Closed

testcase fixes in css/CSS2/borders #10755

wants to merge 5 commits into from

Conversation

faceless2
Copy link
Contributor

@faceless2 faceless2 commented May 2, 2018

Two changes:

  1. border-N-width-applies-to-008.xht tests did not have a reftest and were slightly dependent on default font-metrics (specifically, nbsp being 0.25em wide). Redid to use an image, although they're still testing the same thing. Added a matching reftest

  2. border-color-011.xht was incorrect, result of test has reversed since the rules regarding "currentColor" inheritance were clarified in css-color-4

  3. additional whitespace in bidi-003.xht was causing reftest mismatch

@TalbotG
Copy link
Contributor

TalbotG commented May 2, 2018

@faceless2 (Mike),

In your border-*-width-applies-to-008 tests:
Shouldn't you be saying that it's a square, not a rectangle?

line 26 or 27: <img src="support/1x1-white.png" />
is going to trigger a validation error. Same validation error in your border-n-width-applies-to-008-ref.xht reference file. You need to wrap the img element with a block like a <div>:

Line 27, Column 43: document type does not allow element "img" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", (...)

Also,
alt="Image download support must be enabled"
is missing. We want to know easily and quickly if there are any broken links or incorrect linkage to images.

@TalbotG
Copy link
Contributor

TalbotG commented May 2, 2018

In your border-*-width-applies-to-008 tests:

Since img is used, then

line 18: display: inline;

can be safely removed too.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to border-color-011.xht correctly captures the currentColor changes in css-color-4 (and css-color-3, edited rec).

@faceless2
Copy link
Contributor Author

Closed; reapplied as single patches.

@faceless2 faceless2 closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants