-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testcase fixes in css/CSS2/borders #10755
Conversation
@faceless2 (Mike), In your border-*-width-applies-to-008 tests: line 26 or 27:
Also, |
In your border-*-width-applies-to-008 tests: Since img is used, then line 18: display: inline; can be safely removed too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to border-color-011.xht correctly captures the currentColor changes in css-color-4 (and css-color-3, edited rec).
Closed; reapplied as single patches.
|
Two changes:
border-N-width-applies-to-008.xht tests did not have a reftest and were slightly dependent on default font-metrics (specifically, nbsp being 0.25em wide). Redid to use an image, although they're still testing the same thing. Added a matching reftest
border-color-011.xht was incorrect, result of test has reversed since the rules regarding "currentColor" inheritance were clarified in css-color-4
additional whitespace in bidi-003.xht was causing reftest mismatch