Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebDriver BiDi] cover storage.setCookie domain #43996

Open
35 of 44 tasks
sadym-chromium opened this issue Jan 15, 2024 · 0 comments
Open
35 of 44 tasks

[WebDriver BiDi] cover storage.setCookie domain #43996

sadym-chromium opened this issue Jan 15, 2024 · 0 comments
Assignees
@sadym-chromium
Labels
type:missing-coverage webdriver-bidi

Comments

@sadym-chromium
Copy link
Contributor

sadym-chromium commented Jan 15, 2024 •
edited
Loading

Add coverage for storage.setCookie command, which includes:
Page's protocol:

  • http
  • https

Parameters:

  • cookie: storage.PartialCookie
    • name: text
      • valid
      • invalid
    • value: network.BytesValue
      • StringValue
        • valid
        • invalid
      • Base64Value
        • valid
        • invalid
    • domain: text
      • valid
      • invalid
    • ?path: text
      • valid
      • invalid
    • ?httpOnly: bool
      • valid
      • invalid
    • ?secure: bool
      • valid
      • invalid
    • ?sameSite: network.SameSite
      • strict
      • lax
      • none
      • invalid
    • ?expiry: js-uint
      • valid
      • invalid
  • ?partition
    • type: context
      • valid
      • invalid
    • type: storageKey
      • userContext
        • valid
        • invalid
      • sourceOrigin
        • valid
        • invalid
@sadym-chromium sadym-chromium self-assigned this Jan 15, 2024
@sadym-chromium sadym-chromium mentioned this issue Jan 15, 2024
Merged
sadym-chromium added a commit that referenced this issue Jan 15, 2024
@sadym-chromium
[WebDriver BiDi] extend storage.setCookie tests (#43995)
8b62664 
* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: #43996
---------

Co-authored-by: Maksim Sadym <sadym@google.com>
@sadym-chromium sadym-chromium mentioned this issue Jan 17, 2024
Merged
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 18, 2024
@sadym-chromium @moz-wptsync-bot
Bug 1874654 [wpt PR 43995] - [WebDriver BiDi] extend `storage.setCook…
c560f49 
…ie` tests, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] extend `storage.setCookie` tests (#43995)

* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: web-platform-tests/wpt#43996
---------

Co-authored-by: Maksim Sadym <sadym@google.com>
--

wpt-commits: 8b62664ec7eff59f805181e3c3fade956f177d0c
wpt-pr: 43995
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jan 19, 2024
@marco-c
Bug 1874654 [wpt PR 43995] - [WebDriver BiDi] extend `storage.setCook…
e7c5ec3 
…ie` tests, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] extend `storage.setCookie` tests (#43995)

* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: web-platform-tests/wpt#43996
---------

Co-authored-by: Maksim Sadym <sadymgoogle.com>
--

wpt-commits: 8b62664ec7eff59f805181e3c3fade956f177d0c
wpt-pr: 43995

UltraBlame original commit: c9aba2480c37e2486d3f39e638227a67acac1f00
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jan 19, 2024
@marco-c
Bug 1874654 [wpt PR 43995] - [WebDriver BiDi] extend `storage.setCook…
9b90430 
…ie` tests, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] extend `storage.setCookie` tests (#43995)

* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: web-platform-tests/wpt#43996
---------

Co-authored-by: Maksim Sadym <sadymgoogle.com>
--

wpt-commits: 8b62664ec7eff59f805181e3c3fade956f177d0c
wpt-pr: 43995

UltraBlame original commit: c9aba2480c37e2486d3f39e638227a67acac1f00
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jan 19, 2024
@marco-c
Bug 1874654 [wpt PR 43995] - [WebDriver BiDi] extend `storage.setCook…
d3a8779 
…ie` tests, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] extend `storage.setCookie` tests (#43995)

* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: web-platform-tests/wpt#43996
---------

Co-authored-by: Maksim Sadym <sadymgoogle.com>
--

wpt-commits: 8b62664ec7eff59f805181e3c3fade956f177d0c
wpt-pr: 43995

UltraBlame original commit: c9aba2480c37e2486d3f39e638227a67acac1f00
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Jan 19, 2024
@sadym-chromium @moz-wptsync-bot
Bug 1874654 [wpt PR 43995] - [WebDriver BiDi] extend `storage.setCook…
116f631 
…ie` tests, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] extend `storage.setCookie` tests (#43995)

* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: web-platform-tests/wpt#43996
---------

Co-authored-by: Maksim Sadym <sadym@google.com>
--

wpt-commits: 8b62664ec7eff59f805181e3c3fade956f177d0c
wpt-pr: 43995
marcoscaceres pushed a commit that referenced this issue Feb 23, 2024
@sadym-chromium @marcoscaceres
[WebDriver BiDi] extend storage.setCookie tests (#43995)
a0708ec 
* Cover `context` partition happy case
* Cover `storageKey` partition happy case
* Refactor cookie assertion

Tracking issue: #43996
---------

Co-authored-by: Maksim Sadym <sadym@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadym-chromium sadym-chromium

Labels
type:missing-coverage webdriver-bidi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sadym-chromium