Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/WebCryptoAPI/generateKey/* are disabled/flaky in Mozilla Chromium WebKit #10794

Closed
zcorpan opened this issue May 2, 2018 · 11 comments
Closed
Assignees
Labels

Comments

@zcorpan
Copy link
Member

zcorpan commented May 2, 2018

http://bocoup.github.io/wpt-disabled-tests-report/

Investigate what's up with this test:

Path Products Results Bugs
/WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html mozilla chromium webkit disabled [ Pass Timeout ] [ Pass Failure ] https://bugzilla.mozilla.org/show_bug.cgi?id=1279799 https://crbug.com/787971 None

Edit: also:

  • /WebCryptoAPI/generateKey/test_successes_RSA-PSS.https.html
  • /WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.https.html
  • /WebCryptoAPI/generateKey/successes_RSA-OAEP.https.worker.html
  • /WebCryptoAPI/generateKey/successes_RSA-PSS.https.worker.html
  • /WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.worker.html
@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

@andypaicu @foolip @Hexcles any thoughts on what, if anything, we can do with this test?

The test has this warning

<p>
    <strong>Warning!</strong> RSA key generation is intrinsically
    very slow, so the related tests can take up to
    several minutes to complete, depending on browser!
</p>

@zcorpan zcorpan changed the title /WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html is disabled in Mozilla and flaky in WebKit /WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html is disabled in Mozilla and flaky in Chromium & WebKit May 9, 2018
@foolip
Copy link
Member

foolip commented May 9, 2018

How long does it take to generate a single RSA key? Is the test just trying to generate too many and needs to be split?

@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

For me it seems to take around 1s per subtest, and this has 156 subtests, so yeah, splitting it up to multiple files (or variants) seems reasonable.

@Hexcles
Copy link
Member

Hexcles commented May 9, 2018

This is also tracked in Chromium by the way: https://crbug.com/787971

Splitting the tests seems a reasonable way. Apparently timeout: long isn't enough.

@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

I think it would work to use <meta name="variant" content="?1-10"> to run the first 10 tests, and 11-20 and so on.

@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

@Hexcles yep, my report picked that up :)

zcorpan added a commit that referenced this issue May 14, 2018
Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.

Fixes #10794.
zcorpan added a commit that referenced this issue May 14, 2018
Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.

Fixes #10794.
zcorpan added a commit that referenced this issue May 14, 2018
Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.

Fixes #10794.
zcorpan added a commit that referenced this issue May 14, 2018
Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.

Fixes #10794.
@jgraham
Copy link
Contributor

jgraham commented May 15, 2018

Make sure you test this in Firefox; iirc the generation is slower in Gecko for some (I think intentional) reason.

@zcorpan
Copy link
Member Author

zcorpan commented May 15, 2018

For me it seems slightly faster in Firefox (compared to Chrome), but of course it can depend on the device under test. If 10 subtests is still too much we can do 5 or so. But let's try 10 first.

zcorpan added a commit that referenced this issue May 15, 2018
…ts (#10984)

Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.

Fixes #10794.
@zcorpan zcorpan changed the title /WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html is disabled in Mozilla and flaky in Chromium & WebKit /WebCryptoAPI/generateKey/* are disabled/flaky in Mozilla Chromium WebKit May 16, 2018
@zcorpan
Copy link
Member Author

zcorpan commented Jun 21, 2018

@Hexcles can you update TestExpectations for chromium?

@cdumez can you update TestExpectations for webkit?

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1470130 for gecko.

@zcorpan zcorpan reopened this Jun 21, 2018
@Hexcles
Copy link
Member

Hexcles commented Jun 21, 2018

aarongable pushed a commit to chromium/chromium that referenced this issue Jun 21, 2018
The two WebCryptoAPI tests have been fixed (and renamed) in upstream
(web-platform-tests/wpt#10794) and we can now
safely remove these two expectations.

TBR=foolip

No-Try: True
Bug: 787971
Change-Id: I76a0c288e37ef92c30d936d76d652e65ab9d204b
Reviewed-on: https://chromium-review.googlesource.com/1110738
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569368}
@zcorpan
Copy link
Member Author

zcorpan commented May 8, 2019

@zcorpan zcorpan closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants