Skip to content

Commit

Permalink
Fix check failure at LineBreaker::HandleTextForFastMinContent
Browse files Browse the repository at this point in the history
The DCHECK_EQ fails, because sometimes the decoration width of elements
with `box-decoration-break` is zero, so `position_` will be
equal to `indent`, and the value of `should_break_at_first_opportunity`
will be false. `has_cloned_box_decorations_` is true. So the DCHECK_EQ
fails.

Bug: 362530623
Change-Id: I4523c16089326340c4bab88ae3b674ccb0bdd9ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873209
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Auto-Submit: cathie chen <cchen@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1367328}
  • Loading branch information
Cathie Chen authored and chromium-wpt-export-bot committed Oct 11, 2024
1 parent 4630a18 commit f28c47a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions css/css-break/box-decoration-break-clone-036-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<!DOCTYPE html>
<link rel="author" title="cathie chen" href="mailto:cathiechen@igalia.com">
<link rel="help" href="https://issues.chromium.org/issues/362530623">
<div style="width: min-content;">
<span style="box-decoration-break: clone">PASS if no crash.</span>
</div>

0 comments on commit f28c47a

Please sign in to comment.