-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ResourceTiming] Prefer PerformanceObserver over getEntriesByType in …
…WPTs Older versions of the Resource Timing spec don't specify a strong enough ordering constraint between an element's "onload" and the PerformanceResourceTiming entry being added to the Performance Timeline. As such, our strategy of calling "performance.getEntriesByType()" after the "onload" event fires isn't guaranteed to return the expected entry. This CL modifies our approach to use, and block on, a PerformanceObserver being notified of entries being added to the timeline. This eliminates a class of flakiness we were seeing during manual testing. Bug: 1171767 Change-Id: Ifa4995683f5ef4ff6e53f9780f6d485e6cfb3d81 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826597 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#872849}
- Loading branch information
1 parent
6d4fca7
commit d0d5cb6
Showing
6 changed files
with
35 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters