Use assert_precondition in ElementTiming/LargestContentfulPaint

This CL replaces assert_unreached for assert_precondition for the API existence checks in the ElementTiming and LargestContentfulPaint WPTs. Change-Id: Icd2ff3e045835cf4c46a370a384455143a717308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013863 Reviewed-by: Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734494}
web-platform-tests · Jan 23, 2020 · bd2c049 · bd2c049
1 parent 025c749
commit bd2c049
Show file tree

Hide file tree

Showing 60 changed files with 63 additions and 180 deletions.
diff --git a/element-timing/background-image-data-uri.html b/element-timing/background-image-data-uri.html
@@ -18,9 +18,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/background-image-multiple-elements.html b/element-timing/background-image-multiple-elements.html
@@ -23,9 +23,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     let beforeRender = performance.now();
     let numObservedElements = 0;
     let observedDiv1 = false;

diff --git a/element-timing/background-image-stretched.html b/element-timing/background-image-stretched.html
@@ -18,9 +18,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/buffer-before-onload.html b/element-timing/buffer-before-onload.html
@@ -13,9 +13,7 @@
   is available from the observer with the buffered flag set to true.
   */
   async_test(function(t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     beforeRender = performance.now();
     const img = document.createElement('img');
     img.src = 'resources/square20.jpg';

diff --git a/element-timing/buffered-flag.html b/element-timing/buffered-flag.html
@@ -12,11 +12,9 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test(t => {
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const beforeRender = performance.now();
     const img = document.createElement('img');
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
     // Initial observer used to know when entry has been dispatched
     new PerformanceObserver(() => {
       // Second observer should require buffered flag to receive the already-dispatched entry.

diff --git a/element-timing/cross-origin-element.sub.html b/element-timing/cross-origin-element.sub.html
@@ -12,9 +12,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test((t) => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     let img;
     const pathname = 'http://{{domains[www]}}:{{ports[http][1]}}'
           + '/element-timing/resources/square100.png';

diff --git a/element-timing/cross-origin-iframe-element.sub.html b/element-timing/cross-origin-iframe-element.sub.html
@@ -7,9 +7,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test((t) => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done((entryList) => {
         assert_unreached("We should not observe a cross origin element.");

diff --git a/element-timing/css-generated-text.html b/element-timing/css-generated-text.html
@@ -17,9 +17,7 @@
 <script>
   async_test(function (t) {
     const beforeRender = performance.now();
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/disconnect-image.html b/element-timing/disconnect-image.html
@@ -9,9 +9,7 @@
   let beforeRender;
   let img;
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/element-only-when-fully-active.html b/element-timing/element-only-when-fully-active.html
@@ -7,6 +7,9 @@
 <iframe src="resources/iframe-stores-entry.html" id="ifr"></iframe>
 <script>
   let t = async_test('Only expose element attribute for fully active documents');
+  t.step(() => {
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
+  });
   window.triggerTest = t.step_func_done(elementEntry => {
     assert_not_equals(elementEntry.element, null);
     const iframe = document.getElementById('ifr');

diff --git a/element-timing/first-letter-background.html b/element-timing/first-letter-background.html
@@ -13,9 +13,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const div = document.getElementById('target');
     let textObserved = false;
     let imageObserved = false;

diff --git a/element-timing/fixed-id-identifier.html b/element-timing/fixed-id-identifier.html
@@ -8,9 +8,7 @@
 <p elementtiming='my_identifier' id='my_id'>Text</p>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/image-TAO.sub.html b/element-timing/image-TAO.sub.html
@@ -7,9 +7,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test(t => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const beforeRender = performance.now();
     const remote_img = 'http://{{domains[www]}}:{{ports[http][1]}}/element-timing/resources/TAOImage.py?'
         + 'origin=' + window.location.origin +'&tao=';

diff --git a/element-timing/image-carousel.html b/element-timing/image-carousel.html
@@ -26,9 +26,7 @@
 
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const beforeRenderTimes = [];
     let entry_count = 0;
     const entry_count_per_element = [0, 0];

diff --git a/element-timing/image-clipped-svg.html b/element-timing/image-clipped-svg.html
@@ -7,9 +7,7 @@
 <script>
 let beforeRender;
 async_test(function (t) {
-  if (!window.PerformanceElementTiming) {
-    assert_unreached("PerformanceElementTiming is not implemented");
-  }
+  assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
   const observer = new PerformanceObserver(
     t.step_func_done(function(entryList) {
       assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/image-data-uri.html b/element-timing/image-data-uri.html
@@ -16,9 +16,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/image-not-added.html b/element-timing/image-not-added.html
@@ -5,9 +5,7 @@
 <script src="/resources/testharnessreport.js"></script>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(() => {
         // The image should not have caused an entry, so fail test.

diff --git a/element-timing/image-not-fully-visible.html b/element-timing/image-not-fully-visible.html
@@ -14,9 +14,7 @@
   let beforeRender;
   let img;
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/image-rect-iframe.html b/element-timing/image-rect-iframe.html
@@ -11,9 +11,7 @@
 <script src="/resources/testharnessreport.js"></script>
 <script>
   async_test((t) => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     on_event(window, 'message', e => {
       assert_equals(e.data.length, 1);
       assert_equals(e.data.entryType, 'element');

diff --git a/element-timing/image-src-change.html b/element-timing/image-src-change.html
@@ -13,9 +13,7 @@
 <img src='resources/square100.png' elementtiming='my_image' id='my_id'/>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     let beforeRender = performance.now();
     const img = document.getElementById('my_id');
     let firstCallback = true;

diff --git a/element-timing/image-with-css-scale.html b/element-timing/image-with-css-scale.html
@@ -21,9 +21,7 @@
 <script>
   const beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/image-with-rotation.html b/element-timing/image-with-rotation.html
@@ -21,9 +21,7 @@
 <script>
   const beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/images-repeated-resource.html b/element-timing/images-repeated-resource.html
@@ -20,9 +20,7 @@
   let img;
   let img2;
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/invisible-images.html b/element-timing/invisible-images.html
@@ -16,9 +16,7 @@
 </style>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done((entries) => {
         // The image should not have caused an entry, so fail test.

diff --git a/element-timing/multiple-background-images.html b/element-timing/multiple-background-images.html
@@ -18,9 +18,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     let numObservedElements = 0;
     let observedCircle = false;
     let observedSquare = false;

diff --git a/element-timing/observe-background-image.html b/element-timing/observe-background-image.html
@@ -18,9 +18,7 @@
 <script>
   let beforeRender = performance.now();
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/observe-child-element.html b/element-timing/observe-child-element.html
@@ -12,9 +12,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test((t) => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done((entryList) => {
         assert_unreached("Should not have received an entry!");

diff --git a/element-timing/observe-elementtiming.html b/element-timing/observe-elementtiming.html
@@ -14,9 +14,7 @@
   let beforeRender;
   let img;
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/observe-empty-attribute.html b/element-timing/observe-empty-attribute.html
@@ -7,9 +7,7 @@
 <script>
 let beforeRender;
 async_test(function (t) {
-  if (!window.PerformanceElementTiming) {
-    assert_unreached("PerformanceElementTiming is not implemented");
-  }
+  assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
   let observedImage = false;
   let observedText = false;
   const observer = new PerformanceObserver(

diff --git a/element-timing/observe-multiple-images.html b/element-timing/observe-multiple-images.html
@@ -22,9 +22,7 @@
 <script>
   let beforeRender, image1Observed=0, image2Observed=0, image3Observed=0;
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func(function(entryList) {
         entryList.getEntries().forEach( entry => {

diff --git a/element-timing/observe-shadow-image.html b/element-timing/observe-shadow-image.html
@@ -12,9 +12,7 @@
 <div id='target'></div>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_unreached('Should not observe elements in shadow trees!');

diff --git a/element-timing/observe-shadow-text.html b/element-timing/observe-shadow-text.html
@@ -12,9 +12,7 @@
 <div id='target'></div>
 <script>
   async_test(function (t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const observer = new PerformanceObserver(
       t.step_func_done(function(entryList) {
         assert_unreached('Should not observe text elements in shadow trees!');

diff --git a/element-timing/observe-svg-image.html b/element-timing/observe-svg-image.html
@@ -7,9 +7,7 @@
 <script>
 let beforeRender;
 async_test(function (t) {
-  if (!window.PerformanceElementTiming) {
-    assert_unreached("PerformanceElementTiming is not implemented");
-  }
+  assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
   const observer = new PerformanceObserver(
     t.step_func_done(function(entryList) {
       assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/observe-text.html b/element-timing/observe-text.html
@@ -15,9 +15,7 @@
 <script src="resources/element-timing-helpers.js"></script>
 <script>
   async_test((t) => {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     let paragraph;
     let beforeRender;
     const observer = new PerformanceObserver(

diff --git a/element-timing/observe-video-poster.html b/element-timing/observe-video-poster.html
@@ -7,9 +7,7 @@
 <script>
 let beforeRender;
 async_test(function (t) {
-  if (!window.PerformanceElementTiming) {
-    assert_unreached("PerformanceElementTiming is not implemented");
-  }
+  assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
   const observer = new PerformanceObserver(
     t.step_func_done(function(entryList) {
       assert_equals(entryList.getEntries().length, 1);

diff --git a/element-timing/progressively-loaded-image.html b/element-timing/progressively-loaded-image.html
@@ -14,9 +14,7 @@
   let numInitial = 75;
   let sleep = 500;
   async_test(function(t) {
-    if (!window.PerformanceElementTiming) {
-      assert_unreached("PerformanceElementTiming is not implemented");
-    }
+    assert_precondition(window.PerformanceElementTiming, "PerformanceElementTiming is not implemented");
     const img_src = 'resources/progressive-image.py?name=square20.jpg&numInitial='
       + numInitial + '&sleep=' + sleep;
     const observer = new PerformanceObserver(