Skip to content

Commit

Permalink
[tools] Disable some multiprocessing tests (#24892)
Browse files Browse the repository at this point in the history
on macOS + Python 3.8

#24880
  • Loading branch information
Hexcles authored Aug 5, 2020
1 parent 631a86c commit b2579d4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/serve/test_functional.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import Queue as queue # noqa: N813
except ImportError:
import queue
import sys
import tempfile
import threading

Expand Down Expand Up @@ -45,6 +46,8 @@ def tempfile_name():
os.remove(name)


@pytest.mark.skipif(sys.version_info >= (3, 8) and sys.platform == 'darwin',
reason="multiprocessing test hangs in Python 3.8 on macOS (#24880)")
def test_subprocess_exit(server_subprocesses, tempfile_name):
timeout = 30

Expand Down
4 changes: 4 additions & 0 deletions tools/wpt/tests/test_wpt.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ def test_run_zero_tests():

@pytest.mark.slow
@pytest.mark.remote_network
@pytest.mark.skipif(sys.version_info >= (3, 8) and sys.platform == 'darwin',
reason="multiprocessing test hangs in Python 3.8 on macOS (#24880)")
def test_run_failing_test():
"""Failing tests should be reported with a non-zero exit status unless the
`--no-fail-on-unexpected` option has been specified."""
Expand All @@ -211,6 +213,8 @@ def test_run_failing_test():

@pytest.mark.slow
@pytest.mark.remote_network
@pytest.mark.skipif(sys.version_info >= (3, 8) and sys.platform == 'darwin',
reason="multiprocessing test hangs in Python 3.8 on macOS (#24880)")
def test_run_verify_unstable(temp_test):
"""Unstable tests should be reported with a non-zero exit status. Stable
tests should be reported with a zero exit status."""
Expand Down
3 changes: 3 additions & 0 deletions tools/wptserve/tests/functional/test_stash.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sys
import unittest
import uuid

Expand All @@ -9,6 +10,8 @@
from .base import TestUsingServer


@pytest.mark.skipif(sys.version_info >= (3, 8) and sys.platform == 'darwin',
reason="multiprocessing test hangs in Python 3.8 on macOS (#24880)")
class TestResponseSetCookie(TestUsingServer):
def run(self, result=None):
with StashServer(None, authkey=str(uuid.uuid4())):
Expand Down

0 comments on commit b2579d4

Please sign in to comment.