Skip to content

Commit

Permalink
HighlightRegister was renamed to HighlightRegistry (#44631)
Browse files Browse the repository at this point in the history
  • Loading branch information
annevk authored Feb 19, 2024
1 parent 8fb5ee7 commit 8ca6fb2
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,33 +29,33 @@
tamperMapPrototype();

const highlight = new Highlight(new StaticRange({startContainer: document.body, endContainer: document.body, startOffset: 0, endOffset: 0}));
const highlightRegister = new HighlightRegister();
const highlightRegistry = new HighlightRegistry();

assert_equals(highlightRegister.size, 0);
highlightRegister.set("foo", highlight);
assert_equals(highlightRegister.size, 1);
assert_equals(highlightRegistry.size, 0);
highlightRegistry.set("foo", highlight);
assert_equals(highlightRegistry.size, 1);

assert_true(highlightRegister.has("foo"));
assert_equals([...highlightRegister.entries()][0][0], "foo");
assert_true(highlightRegistry.has("foo"));
assert_equals([...highlightRegistry.entries()][0][0], "foo");

highlightRegister.clear();
assert_equals(highlightRegister.size, 0);
assert_equals(highlightRegister.get("foo"), undefined);
highlightRegistry.clear();
assert_equals(highlightRegistry.size, 0);
assert_equals(highlightRegistry.get("foo"), undefined);

highlightRegister.set("bar", highlight);
assert_equals(highlightRegister.get("bar"), highlight);
assert_equals([...highlightRegister][0][1], highlight);
highlightRegistry.set("bar", highlight);
assert_equals(highlightRegistry.get("bar"), highlight);
assert_equals([...highlightRegistry][0][1], highlight);

highlightRegister.delete("bar");
assert_equals(highlightRegister.size, 0);
assert_false(highlightRegister.has("bar"));
highlightRegistry.delete("bar");
assert_equals(highlightRegistry.size, 0);
assert_false(highlightRegistry.has("bar"));

highlightRegister.set("baz", highlight);
assert_equals([...highlightRegister.keys()][0], "baz");
assert_equals([...highlightRegister.values()][0], highlight);
highlightRegistry.set("baz", highlight);
assert_equals([...highlightRegistry.keys()][0], "baz");
assert_equals([...highlightRegistry.values()][0], highlight);

let callbackCalled = false;
highlightRegister.forEach(() => { callbackCalled = true; });
highlightRegistry.forEach(() => { callbackCalled = true; });
assert_true(callbackCalled);
}, "HighlightRegistry is a maplike interface that works as expected even if Map.prototype is tampered.");
</script>
7 changes: 7 additions & 0 deletions css/css-highlight-api/historical.window.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// https://drafts.csswg.org/css-highlight-api-1/

"use strict";

test(() => {
assert_equals(self.HighlightRegister, undefined);
}, "HighlightRegister was renamed");

0 comments on commit 8ca6fb2

Please sign in to comment.