RFC 121: Add testdriver.js support for Custom Handlers registration #121
Conversation
javifernandez
changed the title
Ms2ger
changed the title
|
Hi @javifernandez. There was a discussion on this. This RFC will be automatically accepted once the HTML change is accepted. But note: there should be webdriver and infrastructure tests |
|
@javifernandez what's the status of whatwg/html#8267, do you expect that to land in HTML soon? |
I'm still working on settle down on the spec text; there are some concepts that are not clear enough yet. Hopefully I could complete this work soon. However, we would need some explicit support from Firefox if we want to land the changes in the HTML spec. I've filed a position-request for Mozilla, and @jgraham offered to comment there, but still no feedback. I assume the positive signals from Chrome (unless you tell me otherwise) since there were no opposition to the intent-to-prototype. |
|
The PR [1] to change the HTML spec has been merged already with the support of Chrome and Firefox, defining a new WebDriver extension command for testing automation with protocol handlers. I'll start implementing the change for ChromeDriver then. [1] whatwg/html#8267 |
The PR#8267 [1] for the HTML spec introduced a new WebDriver extension command to allow testing automation for the registerProtocolHandler method of the Custom Handlers API. This CL adds support in ChromeDriver for such extension command. See also the Web Platform Test PR [2] and RFC [3] for further details. The extension command relies on a new CDP command implemented in a different CL [4]. [1] whatwg/html#8267 [2] web-platform-tests/wpt#35792 [3] web-platform-tests/rfcs#121 [4] https://crrev.com/c/4203529 Bug: 1359103 Change-Id: Ifd4385815ab30a40f46c2f083dc9604024060613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200660 Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#1100968}
|
The PR#35792 is pending of reviews to add the new automated tests, using the new WebDriver command. I guess once it's merged we can do the same with this one. |
gsnedders
left a comment
gsnedders
left a comment
There was a problem hiding this comment.
https://html.spec.whatwg.org/multipage/system-state.html#user-agent-automation is where the command is defined. Per #127 this doesn't require an RFC any more now it's defined in a spec, but let's accept this as-is.
4 participants
Add testdriver.js support for Custom Handlers testing automation.