RFC 101: Add testdriver.js support for Secure Payment Confirmation #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
changed the title
foolip
approved these changes
Oct 27, 2021
| just the currently-open SPC dialog (e.g. `webdriver.accept_spc_prompt`). This | ||
| design is cleaner in terms of being idempotent, however it [led to | ||
| flake](https://chromium-review.googlesource.com/c/chromium/src/+/3225868/11#message-443faa84dfec42cf930bf7bf99e47d35f784bbbc) | ||
| as the web-page is not able to tell exactly when the dialog has been displayed |
Member
There was a problem hiding this comment.
Sorry the future isn't here yet, but with WebDriver BiDi a reasonable design would have been an event when the dialog is shown, and then a command to interact with the dialog.
This was referenced Oct 27, 2021
Member
|
1 week has passed, I'm merging this. |
T3-M4
pushed a commit
to bayandin/chromedriver
that referenced
this pull request
Nov 5, 2021
See: - w3c/secure-payment-confirmation#151 - web-platform-tests/rfcs#101 Bug: 1241090 Change-Id: Ic809485d91c11b6cc70e80e17eee88290a0e90f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251001 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/main@{#938409}
pull bot
pushed a commit
to Alan-love/chromium
that referenced
this pull request
Nov 5, 2021
See: - w3c/secure-payment-confirmation#151 - web-platform-tests/rfcs#101 Bug: 1241090 Change-Id: Ic809485d91c11b6cc70e80e17eee88290a0e90f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251001 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/main@{#938409}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.