Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input type=week/month #88

Closed
gsnedders opened this issue Jun 17, 2022 · 6 comments
Closed

input type=week/month #88

gsnedders opened this issue Jun 17, 2022 · 6 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@gsnedders
Copy link
Member

** Test List **

  • /html/dom/reflection-forms.html
  • /html/semantics/forms/constraints/form-validation-validity-rangeOverflow.html
  • /html/semantics/forms/constraints/form-validation-validity-rangeUnderflow.html
  • /html/semantics/forms/constraints/form-validation-validity-valid.html
  • /html/semantics/forms/constraints/form-validation-validity-valueMissing.html
  • /html/semantics/forms/the-input-element/datetime.html
  • /html/semantics/forms/the-input-element/input-stepdown.html
  • /html/semantics/forms/the-input-element/input-stepup.html
  • /html/semantics/forms/the-input-element/selection.html
  • /html/semantics/forms/the-input-element/type-change-state.html
  • /html/semantics/forms/the-input-element/valueMode.html

** Rationale **

Per #11 (comment) we agreed to exclude these previously, but the tests were never split.
@gsnedders gsnedders added the test-change-proposal Proposal to add or remove tests for an interop area label Jun 17, 2022
@foolip
Copy link
Member

foolip commented Jun 22, 2022

@mfreed7 @josepharhar can either of you look into splitting these tests? I know that at least one test was split, but don't know if there's a pending CL/PR for the rest?

@foolip foolip mentioned this issue Jun 22, 2022
Closed
@josepharhar
Copy link

I'll try splitting these

@josepharhar
Copy link

I split them here: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
I'll post a link to the generated WPT PR which should have test results soon

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 23, 2022
@josepharhar @chromium-wpt-export-bot
Split week and month input types from forms WPTs
0065a48 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 23, 2022
@josepharhar @chromium-wpt-export-bot
Split week and month input types from forms WPTs
f9d9800 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
@josepharhar
Copy link

Here is the WPT PR for the changes: web-platform-tests/wpt#34560
If nobody objects I'll merge it soon

@josepharhar
Copy link

I'm going to merge the PR.
The last build of it failed because it couldn't install safari: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=83434&view=logs&j=bf8f5026-3d1f-5955-26be-17f9e1ef0bb3&t=fb374013-b51a-5838-c2f2-591e11e493ab&l=19
The firefox results look good though, so hopefully I didn't make any mistakes when splitting the tests.

aarongable pushed a commit to chromium/chromium that referenced this issue Jun 29, 2022
@josepharhar
Split week and month input types from forms WPTs
525b3e2 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 29, 2022
@josepharhar @chromium-wpt-export-bot
Split week and month input types from forms WPTs
cfe1c1e 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 29, 2022
@josepharhar @chromium-wpt-export-bot
Split week and month input types from forms WPTs
b489bce 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 5, 2022
@josepharhar @moz-wptsync-bot
Bug 1776257 [wpt PR 34560] - Split week and month input types from fo…
a1b344f 
…rms WPTs, a=testonly

Automatic update from web-platform-tests
Split week and month input types from forms WPTs

This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}

--

wpt-commits: b489bcee65de1d20ce5e8ed8fef16babb4c50763
wpt-pr: 34560
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jul 7, 2022
@josepharhar @moz-wptsync-bot
Bug 1776257 [wpt PR 34560] - Split week and month input types from fo…
5b00252 
…rms WPTs, a=testonly

Automatic update from web-platform-tests
Split week and month input types from forms WPTs

This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}

--

wpt-commits: b489bcee65de1d20ce5e8ed8fef16babb4c50763
wpt-pr: 34560
@foolip
Copy link
Member

foolip commented Jul 13, 2022

Thanks for sorting this out, @josepharhar!

@foolip foolip closed this as completed Jul 13, 2022
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@josepharhar @copybara-github
Split week and month input types from forms WPTs
d87df18 
This was requested here:
web-platform-tests/interop#88

Change-Id: Id8792317129552efb39d872c0e12a597cf269ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721798
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019385}
NOKEYCHECK=True
GitOrigin-RevId: 525b3e2f165448cd3d4ea3b94df193bfedf24a9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @foolip @josepharhar