-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Caniuse keys #2476
Open
jamesnw
wants to merge
7
commits into
web-platform-dx:main
Choose a base branch
from
oddbird:caniuse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add more Caniuse keys #2476
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
821b7dc
Add caniuse matches
jamesnw fb84fe4
Add more caniuse keys
jamesnw 5486794
Add cq units
jamesnw 77b19af
Revise comment
jamesnw 2a826e3
Add more caniuse
jamesnw 085da01
Add canisue to background
jamesnw 08ed78f
Merge branch 'main' into caniuse
jamesnw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
name: Beacons | ||
description: The `navigator.sendBeacon()` method asynchronously sends an HTTP POST request with a limited amount of data, typically for app state, events, and analytics data. The one-way beacon is guaranteed to be initiated before the browser unloads the page, but the sender does not get to handle the response. | ||
spec: https://w3c.github.io/beacon/ | ||
caniuse: beacon | ||
compat_features: | ||
- api.Navigator.sendBeacon |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there also a caniuse entry for named colors? If not, is it ok to only have a caniuse entry that corresponds to a sub-part of our feature, or is there a risk that this would be confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not a caniuse entry for named colors. It's a valid question, though. For the main use case of caniuse adding a Baseline banner to
rebeccapurple
, it would not be confusing. But are there other potential uses of a caniuse key that this would break?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our docs say
Setting a
caniusevalue says that a feature is approximately equivalent to or a superset of a Can I Use feature.
Since named-colors contains rebeccapurple on web-features, this is okay. I'll open a separate PR with another set of similar situations I identified, but in many cases, it looks like the subfeature that caniuse has as a standalone feature has a distinct support story.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going back through my list, most of the superset features have significant discrepancies, so I ended up just adding caniuse for
display
,events
, andfont-kerning
on this branch. Apologies for adding after the approval!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe I can give a better idea of when we ought to map to caniuse. We should map to a feature when both of these criteria are satisfied:
The web-features entry is equivalent to or a superset of the caniuse feature. This caniuse mapping is fine here.
The web-features headline status is correct for the feature on caniuse. This caniuse mapping is fine here.
Theoretically, we should make sure the keystone versions line up, but we should do that in the course of some automation, like Automatically report on discrepancies with caniuse #1880.
That said, we should probably not map to a caniuse feature when caniuse should or intends to represent a web-features entry separately of a corresponding caniuse feature (e.g., if Alexis told us he wanted to have a feature for named colors, we should break link to caniuse). This seems fine for now, but it's a bit conditional. Alexis may choose to import unmapped features into caniuse, so if/when that starts happening we may want to unwind some mappings (this seems like a likely candidate).
On the whole, I think this mapping is fine—it's helpful to caniuse users today—but I don't think it's set in stone.