Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CSS abstract types to existing property features #2149

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Nov 5, 2024

Split off from existing PR: #2111

Keys related to abstract types are distributed to existing property features most associated with that type, where that would not change the support status of the feature

A few orphan keys remain with no associated properties:

  - css.types.frequency
  - css.types.frequency-percentage
  - css.types.frequency.hz
  - css.types.frequency.khz
  - css.types.time-percentage

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 5, 2024
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This distribution makes sense to me.

For the remaining keys-

  • Frequency, could they be their own feature?
  • time-percentage- could that go in to animations-css with time?

Alternatively, should they get added to some sort of CSS catchall? Or removed from BCD, since they aren't used at all?

@ddbeck What should we do about the keys that are in BCD, and in the spec, but are not actually usable anywhere?

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 6, 2024

@ddbeck What should we do about the keys that are in BCD, and in the spec, but are not actually usable anywhere?

I've opened mdn/browser-compat-data#24969 to remove the <frequency> and <frequency-percentage> types. I'm very confident they do not belong in BCD, at all.

That leaves <time-percentage>. Is that also not used in any actual properties? If so, I'd be happy to open a PR against BCD to remove that too.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks right to me. If <time-percentage> is definitely unused, then this is ready to merge. Thank you!

@jamesnw
Copy link
Collaborator

jamesnw commented Nov 6, 2024

@ddbeck Victor and I have not been able to find any references to time-percentage in the specs, and can't find any use cases. I think it can be removed as well.

@jamesnw jamesnw merged commit 9d4f8aa into web-platform-dx:main Nov 6, 2024
3 checks passed
@jamesnw jamesnw deleted the css-values-5--distribute-keys branch November 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants