Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a key to SVG #2054

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add a key to SVG #2054

merged 1 commit into from
Oct 29, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Oct 23, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 23, 2024
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think stroke-color should be part of SVG. Per the spec, it should apply to both text and svg elements, but currently only Safari does that, and the prefixed -webkit-text-stroke-color is part of the compat standard.

Alternatively, since it only works cross-platform in SVG, we could include it here, and then when a BCD key like css.properties.stroke-color.non-svg-text is added, we could create a separate feature.

Which makes the most sense?

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Oct 29, 2024

Thanks for the feedback! I basically added this to SVG because all the other stroke-* properties are there already.
Do we need to look at the stroke-* properties again and decide for one of your options?

Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look, and it looks like all the stroke- properties in https://drafts.fxtf.org/fill-stroke-3/ are supposed to apply to text as well, so this isn't the outlier I thought. I think probably right now we should merge this in, and down the road we'll need to add a feature with BCD keys like css.properties.stroke-color.non-svg-text

@jamesnw jamesnw merged commit ee9990b into web-platform-dx:main Oct 29, 2024
3 checks passed
@Elchi3 Elchi3 deleted the moar-svg branch October 29, 2024 14:01
vwallen pushed a commit to oddbird/web-features that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants