Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more keys to XHR feature #1963

Merged
merged 4 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions features/draft/spec/xhr.yml

This file was deleted.

71 changes: 0 additions & 71 deletions features/draft/spec/xhr.yml.dist

This file was deleted.

8 changes: 8 additions & 0 deletions features/xhr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ compat_features:
- api.FormData
- api.FormData.append
- api.FormData.append.filename_parameter
- api.FormData.delete
- api.FormData.get
- api.FormData.getAll
- api.FormData.has
- api.FormData.set
- api.FormData.FormData
- api.ProgressEvent
- api.ProgressEvent.ProgressEvent
- api.ProgressEvent.lengthComputable
- api.ProgressEvent.loaded
- api.ProgressEvent.total
Expand All @@ -30,6 +36,8 @@ compat_features:
- api.XMLHttpRequest.readystatechange_event
- api.XMLHttpRequest.response
- api.XMLHttpRequest.responseText
- api.XMLHttpRequest.responseType
- api.XMLHttpRequest.responseURL
- api.XMLHttpRequest.responseXML
- api.XMLHttpRequest.send
- api.XMLHttpRequest.send.body_ArrayBuffer_type
Expand Down
56 changes: 56 additions & 0 deletions features/xhr.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,59 @@ compat_features:
- api.XMLHttpRequest.timeout
- api.XMLHttpRequest.timeout_event
- api.XMLHttpRequestUpload.timeout_event

# baseline: high
# baseline_low_date: 2016-08-02
# baseline_high_date: 2019-02-02
# support:
# chrome: "16"
# chrome_android: "18"
# edge: "14"
# firefox: "18"
# firefox_android: "18"
# safari: "6"
# safari_ios: "6"
- api.ProgressEvent.ProgressEvent

# baseline: high
# baseline_low_date: 2016-08-02
# baseline_high_date: 2019-02-02
# support:
# chrome: "37"
# chrome_android: "37"
# edge: "14"
# firefox: "32"
# firefox_android: "32"
# safari: "8"
# safari_ios: "8"
- api.XMLHttpRequest.responseURL

# baseline: high
# baseline_low_date: 2016-11-15
# baseline_high_date: 2019-05-15
# support:
# chrome: "31"
# chrome_android: "31"
# edge: "12"
# firefox: "6"
# firefox_android: "50"
# safari: "5.1"
# safari_ios: "5"
- api.XMLHttpRequest.responseType

# baseline: high
# baseline_low_date: 2018-10-02
# baseline_high_date: 2021-04-02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new formdata keys became baseline hight quite a bit later than the other keys already in there. But they're still old enough that this shouldn't matter.

# support:
# chrome: "50"
# chrome_android: "50"
# edge: "18"
# firefox: "39"
# firefox_android: "39"
# safari: "11.1"
# safari_ios: "11.3"
- api.FormData.delete
- api.FormData.get
- api.FormData.getAll
- api.FormData.has
- api.FormData.set