Add missing grid keys #1854
Add missing grid keys #1854
Conversation
github-actions
bot
added
the
feature definition
|
@mirisuzanne Can you verify that none of the new keys in the dist are features that are separate from what's already in the grid feature? |
features/grid.yml.dist
Outdated
| - css.properties.grid-auto-flow.column | ||
| - css.properties.grid-auto-flow.dense | ||
| - css.properties.grid-auto-flow.row |
There was a problem hiding this comment.
These version ranges make no sense. I sent mdn/browser-compat-data#24539 to fix this so it matches the other Safari 10.1 items.
There was a problem hiding this comment.
@ddbeck I've updated the dist with the BCD changes here, and it looks much better.
There was a problem hiding this comment.
@jamesnw There are some potential overlapping features here – alignment, gap – that work in various layout models, and the list changes over time. The grid_context qualifier makes those keys specific to the grid feature, and I think that's probably a fine choice.
Gap in flexbox context arrived late (after flexbox), and allignment in block context is fairly new (despite blocks being old) - so it won't always work to combine these things in the other places. But I think that's also probably fine?
This is a place where it might be useful at some point to have overlapping features.
The confusingly named flex type is correctly associated with Grid and not Flexbox. 🤷🏻♀️
None of these keys seem to warrant new features. The
grid-auto-flowkeys have incorrect Safari data, but will likely have the same support as the other added keys once that is resolved on BCD.