Add background group #1846
Add background group #1846
Conversation
github-actions
bot
added
the
feature definition
|
Looks good and will help for the remainder |
There was a problem hiding this comment.
OK, I've left some commentary on the descriptions (I thought I had a more substantive issue to raise, but it didn't survive closer inspection). Everything is strictly optional, so pick and choose what you'd like to do here and merge—I can open a follow up PR if there's anything that requires further discussion.
| # firefox_android: "25" | ||
| # safari: "15.4" | ||
| # safari_ios: "15.4" | ||
| - css.properties.background-attachment.local |
There was a problem hiding this comment.
Can you file a bug or PR with caniuse, showing that this whole feature is fully supported? This issue has been resolved and it seems like caniuse just hasn't caught on yet. https://bugs.webkit.org/show_bug.cgi?id=219324
There was a problem hiding this comment.
Opened Fyrd/caniuse#7178
features/background-size.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: background-size | |||
| description: The `background-size` CSS property sets the size of a background layer with the `contain` and `cover` keywords, or with a length or percentage. | |||
There was a problem hiding this comment.
An idea for you, on how to make this a little more concrete:
| description: The `background-size` CSS property sets the size of a background layer with the `contain` and `cover` keywords, or with a length or percentage. | |
| description: The `background-size` CSS property scales or stretches a background based on the size of the element (with the `contain` and `cover` keywords), a length, or percentage. |
features/background-attachment.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: background-attachment | |||
| description: The `background-attachment` CSS property sets whether the background layers of an element move as the element scrolls. | |||
There was a problem hiding this comment.
I'm not super comfortable with "background layer" (I'm thinking of writing defensively due to @layer), so I'm going to try suggesting some changes here. Consider all of the "layer"-only suggestions optional—I'm happy to open a follow up PR if you prefer.
| description: The `background-attachment` CSS property sets whether the background layers of an element move as the element scrolls. | |
| description: The `background-attachment` CSS property sets whether an element's background image or gradient moves as the element scrolls. |
There was a problem hiding this comment.
This is a good point, and I don't think your rewrites introduced ambiguity, they look good to me!
features/background-color.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| name: background-color | |||
| description: The `background-color` CSS property sets the fill color of an element, behind any content and background layers. | |||
There was a problem hiding this comment.
| description: The `background-color` CSS property sets the fill color of an element, behind any content and background layers. | |
| description: The `background-color` CSS property sets the fill color of an element, behind any content and background images or gradients. |
features/background.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| name: background | |||
| description: The `background` CSS property is a shorthand that sets the properties of the background layers of an element. | |||
There was a problem hiding this comment.
| description: The `background` CSS property is a shorthand that sets the properties of the background layers of an element. | |
| description: The `background` CSS property is a shorthand that sets several background properties at once. |
background-position has an interesting support story, will do that as a separate PR.