-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object-fit and object-position #1831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems not right to have >1 Caniuse mapping, I posted to the channel for broader discussion and input.
The only other comment I have is around the replaced element
terminology, which seems more on the spec language end of the spectrum than developer/designer POV (esp new learners). If you're using that everywhere already, then maybe not an issue (or a broader one), but doesn't block merging this either way.
On the caniuse question @autonome highlighted: Narrowly, caniuse mappings should be one-to-one or one-or-many. As far as I know, we have no features yet that are many-to-one. It would be unhelpful to show multiple statuses for a single caniuse feature, so I think many-to-one also doesn't make sense. I think we ought to pick one of these to have the caniuse mapping and drop it from the other. In the future, when we have feature composition nailed down, a feature combining Long-term, I'd like it if web-features could take any reasonable address/identifier (e.g., caniuse's |
@@ -0,0 +1,11 @@ | |||
name: object-fit | |||
description: The `object-fit` CSS property sets how images, videos, and other replaced elements are scaled within their container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I endorse "replaced element" here—you've already said what it is through examples, so we're doing a little developer education while we're at it.
…bject-fit-position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
They both use
caniuse: object-fit
, but I'm not sure if multiple features can share a feature key.Also adds missing
object-view-box
key.